ZA_2-Nishka-Kisten-CodeYourFuture / HTML-CSS-Module-Project-Week_3#357
ZA_2-Nishka-Kisten-CodeYourFuture / HTML-CSS-Module-Project-Week_3#357Nishka-Kisten wants to merge 2 commits into
Conversation
Riyaazct
left a comment
Riyaazct
left a comment
There was a problem hiding this comment.
Nice use of sematic tags, classes and indentation.
One thing you could look into for the future though, is perhaps adding comments to your index.html file to signify either the beginning or end of a section like you did with the CSS file.
|
@Riyaazct Thanks for the advice, shall I edit my code? |
You can if you'd like to but it's not that big of a website and easy to read as it is. |
Mathias02
left a comment
Mathias02
left a comment
There was a problem hiding this comment.
Hi, Nishka, would you please review my Karma project and pull a request to suggest changes,
| <p class="hero_p">Bring WiFi with you, everywhere you go.</p> | ||
| <button class="btn">Learn More</button> | ||
| </section> | ||
| <h2>Everyone needs a little Karma.</h2> |
There was a problem hiding this comment.
This h2 is left alone who's child is it here? please get it a parent,
| <button class="btn">Learn More</button> | ||
| </section> | ||
| <h2>Everyone needs a little Karma.</h2> | ||
| <section class="container"> |
There was a problem hiding this comment.
Changing these divs inside your section into articles would be something better than keeping divs
Mathias02
left a comment
Mathias02
left a comment
There was a problem hiding this comment.
Nishka, please review my Karma project
3 participants
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
The Nav Bar and footer
What did you find hard?
It was a little difficult lining my text underneath the images and the hero element.
What do you still not understand?
I understand everything to a certain limit.
Any other notes?
No.